ASPP/2024-heraklion-git
9
0
Fork 24
Code Issues 2 Pull requests 15 Actions Packages Projects Releases Wiki Activity

implement sha256 hashing of password for security reason #7

Merged
otizonaizit merged 3 commits from romaingu/2024-heraklion-git:hash_pwd into main 2024-08-26 14:40:13 +02:00
Conversation 3 Commits 3 Files changed 1 +14 -5
romaingu commented 2024-08-26 14:11:02 +02:00
Member
Copy link
No description provided.
romaingu added 4 commits 2024-08-26 14:11:03 +02:00 
# doc.python.org
otizonaizit commented 2024-08-26 14:15:25 +02:00
Owner
Copy link

you are fixing two issues simultaneously here:

  • add hashing
  • fix the password leak in add_user

can you please create two separate PRs for the two issues?

you are fixing two issues simultaneously here: - add hashing - fix the password leak in add_user can you please create two separate PRs for the two issues?
otizonaizit commented 2024-08-26 14:19:23 +02:00
Owner
Copy link

good idea to leverage the Python hashing library!

good idea to leverage the Python hashing library!
romaingu commented 2024-08-26 14:20:36 +02:00
Author
Member
Copy link

Hi @otizonaizit ,

can you please create two separate PRs for the two issues?
that's a good idea can you tell us how ?

Hi @otizonaizit , > can you please create two separate PRs for the two issues? that's a good idea can you tell us how ?
romaingu force-pushed hash_pwd from 33720c9b63 to de4dc255ac 2024-08-26 14:38:22 +02:00 Compare
otizonaizit merged commit 4f77cc464f into main 2024-08-26 14:40:13 +02:00
zbyszek reviewed 2024-08-26 14:42:25 +02:00
auth.py
@ -32,0 +35,4 @@
m = sha256()
m.update(encoded_pwd)
return m.hexdigest()
zbyszek commented 2024-08-26 14:39:18 +02:00
Owner
Copy link

Too many empty lines here.

Too many empty lines here.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ASPP/2024-heraklion-git#7
No description provided.
Delete branch "romaingu/2024-heraklion-git:hash_pwd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?