ASPP/2024-heraklion-parallel-python
8
0
Fork 21
Code Issues Pull requests 9 Actions Packages Projects Releases Wiki Activity

add code for best plot eva #2

Open
alessiase wants to merge 1 commit from alessiase/2024-heraklion-parallel-python:best_plot_eva into main
pull from: alessiase/2024-heraklion-parallel-python:best_plot_eva
merge into: ASPP:main
Conversation 0 Commits 1 Files changed 2 +8 -6
alessiase commented 2024-08-30 11:17:17 +02:00
Member
Copy link

<3<3

<3<3
alessiase added 1 commit 2024-08-30 11:17:17 +02:00
zbyszek approved these changes 2024-08-30 11:25:38 +02:00
zbyszek left a comment
Owner
Copy link

LGTM, apart from the minor style issue.

LGTM, apart from the minor style issue.
exercises/exerciseA/plot.py
@ -19,3 +20,1 @@
# CREATE YOUR PLOT HERE
# Remember to label your axis
# Feel free to make it pretty
axs.scatter(x=threads, y=timings, color = 'hotpink', marker = '*')
zbyszek commented 2024-08-30 11:25:25 +02:00
Owner
Copy link

It's a bit strange that spaces are used around the second two assignments, but not the first two.
In Python we generally don't use the spaces in this context.

It's a bit strange that spaces are used around the second two assignments, but not the first two. In Python we generally don't use the spaces in this context.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u best_plot_eva:alessiase-best_plot_eva
git checkout alessiase-best_plot_eva

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff alessiase-best_plot_eva
git checkout main
git merge --ff-only alessiase-best_plot_eva
git checkout alessiase-best_plot_eva
git rebase main
git checkout main
git merge --no-ff alessiase-best_plot_eva
git checkout main
git merge --squash alessiase-best_plot_eva
git checkout main
git merge --ff-only alessiase-best_plot_eva
git checkout main
git merge alessiase-best_plot_eva
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
zbyszek
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ASPP/2024-heraklion-parallel-python#2
No description provided.
Delete branch "alessiase/2024-heraklion-parallel-python:best_plot_eva"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?