ASPP/2024-heraklion-parallel-python
8
0
Fork 21
Code Issues Pull requests 9 Actions Packages Projects Releases Wiki Activity

add code for best plot eva #2

Open
alessiase wants to merge 1 commit from alessiase/2024-heraklion-parallel-python:best_plot_eva into main
pull from: alessiase/2024-heraklion-parallel-python:best_plot_eva
merge into: ASPP:main
Conversation 0 Commits 1 Files changed 2 +8 -6
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c694a89979 - Show all commits

10
exercises/exerciseA/plot.py
View file

@ -7,6 +7,7 @@ threads, timings = [], []
for file in os.listdir('timings'): for file in os.listdir('timings'):
with open(f'timings/{file}', 'r') as f: with open(f'timings/{file}', 'r') as f:
n, t = f.read().strip().split(',') n, t = f.read().strip().split(',')
if n != 'None':
threads.append(int(n)) threads.append(int(n))
timings.append(float(t)) timings.append(float(t))
threads = np.array(threads) threads = np.array(threads)
@ -16,8 +17,9 @@ print('This is the data I loaded: threads =', threads, ', timings =',timings)
fig, axs = plt.subplots() fig, axs = plt.subplots()
# CREATE YOUR PLOT HERE axs.scatter(x=threads, y=timings, color = 'hotpink', marker = '*')
zbyszek commented 2024-08-30 11:25:25 +02:00
Review
Copy link

It's a bit strange that spaces are used around the second two assignments, but not the first two.
In Python we generally don't use the spaces in this context.

It's a bit strange that spaces are used around the second two assignments, but not the first two. In Python we generally don't use the spaces in this context.
# Remember to label your axis axs.set_xlabel('Number of threads')
# Feel free to make it pretty axs.set_ylabel('Timing [s]')
axs.grid()
plt.savefig('threads_v_timings.png', dpi=300) plt.savefig('threads_v_timings', dpi=300)

BIN
exercises/exerciseA/threads_v_timings.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 44 KiB